Skip to content

chore(eap): double write to eap items in tests#86931

Merged
davidtsuk merged 1 commit into
masterfrom
david/chore/write-to-eap-items-for-tests
Mar 12, 2025
Merged

chore(eap): double write to eap items in tests#86931
davidtsuk merged 1 commit into
masterfrom
david/chore/write-to-eap-items-for-tests

Conversation

@davidtsuk

Copy link
Copy Markdown
Contributor

Tests should write to both the eap_spans entity and eap_items.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 12, 2025
@davidtsuk davidtsuk requested a review from wmak March 12, 2025 20:13
@volokluev

Copy link
Copy Markdown
Member

you could also do this in the snuba eventstream endpoint that these functions are hitting, that way you would have full coverage

@davidtsuk davidtsuk merged commit c514497 into master Mar 12, 2025
@davidtsuk davidtsuk deleted the david/chore/write-to-eap-items-for-tests branch March 12, 2025 21:27
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants