Skip to content

ref(debugger-modal): Replace sentry-wizard callout with configs info#87073

Merged
priscilawebdev merged 8 commits into
masterfrom
priscila/ref/debugger-modal/hide-wizard-part-for-meta-platforms
Mar 20, 2025
Merged

ref(debugger-modal): Replace sentry-wizard callout with configs info#87073
priscilawebdev merged 8 commits into
masterfrom
priscila/ref/debugger-modal/hide-wizard-part-for-meta-platforms

Conversation

@priscilawebdev

@priscilawebdev priscilawebdev commented Mar 14, 2025

Copy link
Copy Markdown
Member

For some meta frameworks, we already prompt users to use the Sentry wizard during onboarding, which automatically configures sourcemap uploads to Sentry. Instead of prompting them again in the Debugger Modal, we want to guide them to verify their configuration. Below, you'll see the changes: the image on the left shows the previous version, and the one on the right shows the new changes.

Next.js

Before After
Image Image

Nuxt

Before After
Image Image

Remix

Before After
Image Image

Sveltekit

Before After
Image Image

Other platforms

Before After
Image Image

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 14, 2025
Comment on lines +427 to +428
orgSlug={this.props.organization?.slug}
projectId={this.props.event.projectID}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could have reused the orgSlug and project present in analyticsParams prop, but I prefer it to be explicit

@priscilawebdev priscilawebdev marked this pull request as ready for review March 14, 2025 09:51
@priscilawebdev priscilawebdev requested a review from a team as a code owner March 14, 2025 09:51
Comment thread static/app/components/events/interfaces/sourceMapsDebuggerModal.tsx
Comment thread static/app/components/events/interfaces/sourceMapsDebuggerModal.tsx Outdated
Comment thread static/app/components/events/interfaces/sourceMapsDebuggerModal.tsx Outdated
Comment thread static/app/components/events/interfaces/sourceMapsDebuggerModal.tsx Outdated
Comment thread static/app/components/events/interfaces/sourceMapsDebuggerModal.tsx
@andreiborza

Copy link
Copy Markdown
Member

This looks great! So much better than what we had before. Thanks for adding these.

@smeubank

smeubank commented Mar 19, 2025

Copy link
Copy Markdown
Contributor

Yes this looks great! Thanks @priscilawebdev

2 things:

  1. Should we also link to the framework specific docs on config?

Nuxt link here, and Next link here for example.

  1. should we be populating -org and -project slugs in the wizard snippet too? This should provide similar benefits as the SDK wizards where this was added

npx @sentry/wizard@latest -i sourcemaps --saas --org org-slug --project project-slug

@priscilawebdev

Copy link
Copy Markdown
Member Author

Good points @smeubank 👏 updating now.

Comment thread static/app/components/events/interfaces/sourceMapsDebuggerModal.tsx Outdated
Comment thread static/app/components/events/interfaces/sourceMapsDebuggerModal.tsx Outdated
@priscilawebdev priscilawebdev merged commit 19b8cc9 into master Mar 20, 2025
@priscilawebdev priscilawebdev deleted the priscila/ref/debugger-modal/hide-wizard-part-for-meta-platforms branch March 20, 2025 06:54
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants