ref(span-buffer): Disable multiprocessing by default#87268
Merged
Conversation
We have an issue with multiprocessing where this particula consumer hangs on startup. When we dump stacks, we see it's deep in the multiprocessing stdlib functions, on some IPC read() call. It's not clear what causes this right now. The issue is not reproducible in development, and has been happening inconsistently in the tf-sandbox
github-actions
Bot
added
the
Scope: Backend
jan-auer
approved these changes
Mar 18, 2025
jan-auer
approved these changes
Mar 18, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #87268 +/- ##
==========================================
- Coverage 87.73% 87.73% -0.01%
==========================================
Files 9863 9863
Lines 558345 558332 -13
Branches 22030 22024 -6
==========================================
- Hits 489888 489875 -13
Misses 68050 68050
Partials 407 407 |
github-actions
Bot
added
the
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
untitaker
force-pushed
the
ref/span-buffer-disable-multiprocessing
branch
from
75b40e1 to
7eac6d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have an issue with multiprocessing where this particular consumer
hangs on startup. When we dump stacks, we see it's deep in the
multiprocessing stdlib functions, on some IPC read() call.
It's not clear what causes this right now. The issue is not
reproducible in development, and has been happening inconsistently in
the tf-sandbox