feat(explore): updates explore saved query serializer param to be an array#87503
Merged
edwardgou-sentry merged 3 commits intoMar 24, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #87503 +/- ##
===========================================
+ Coverage 45.07% 87.74% +42.66%
===========================================
Files 9881 9899 +18
Lines 560636 561440 +804
Branches 22139 22119 -20
===========================================
+ Hits 252714 492640 +239926
+ Misses 307520 68396 -239124
- Partials 402 404 +2 |
0649360 to
c4822a8
Compare
…upport-multi-query
narsaynorath
approved these changes
Mar 24, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 27, 2025
…array (#87503) Adds a new inner `QuerySerializer` to contain `fields`, `orderby`, `groupby`, `query`, `visualize`, and `mode` params. Updates `query` in `ExploreSavedQuerySerializer` to now be a list of `QuerySerializer`. This change is to provide support for saving Explore Multi Query views. Multiple queries in a Multi Query view is represented through multiple `QuerySerializer` entries. Single Explore Query views will be saved using a list with a single `QuerySerializer` element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new inner
QuerySerializerto containfields,orderby,groupby,query,visualize, andmodeparams.Updates
queryinExploreSavedQuerySerializerto now be a list ofQuerySerializer.This change is to provide support for saving Explore Multi Query views. Multiple queries in a Multi Query view is represented through multiple
QuerySerializerentries. Single Explore Query views will be saved using a list with a singleQuerySerializerelement.A migration isn't necessary for this change, because no changes were made to the model. Also, because the
queryattribute in theExploreSavedQueryis already aJSONField, which supports storing lists.ie the
querycolumn before:the
querycolumn after: