ref(grouping): Change designations for enhancement actions and rules

[lobsterkatie]

In our current grouping enhancements code, we designate actions (and thereby rules containing said actions) as "modifiers" and/or "updaters," and we provide the ability to split a rule which is both into a modifier version and an updater version. There are two problems with that: 1) Updating and modifying are effectively synonymous concepts, and so it's not at all clear what it means to be one or the other. 2) We actually shouldn't even have this code anymore, because it's a relic of both the pre-rust-enhancements era and the hierarchical grouping era, and is no longer used.

Rather than remove the code, though, we can actually repurpose it. During ingest, we run the stacktrace through the rules twice, once to assign in_app and category values to frames, and once to set contributes values on both the frames and the overall stacktrace. Being able to split a given set of rules into ones useful for the first task and ones useful for the second task would actually be helpful, because at each stage it would allow us to avoid checking rules we know won't apply. It also would solve the problem of "marked in-app by rule x" hints clobbering "ignored by rule x" hints (and vice versa) in cases where a single rule has both effects.

This PR therefore changes the existing designations from is_modifier and is_updater to is_classifier and sets_contributes (for actions) and has_classifier_actions and has_contributes_actions (for rules). Further changes to use this information will come in follow-up PRs.

Note to reviewers: I super don't love the non-parallel naming with is_classifier and sets_contributes, but I struggled to find anything with parallel structure that wasn't horribly ungrammatical. Definitely open to ideas here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #87655       +/-   ##
===========================================
+ Coverage   51.76%   87.74%   +35.98%     
===========================================
  Files        9882     9893       +11     
  Lines      561062   561575      +513     
  Branches    22134    22134               
===========================================
+ Hits       290427   492780   +202353     
+ Misses     270234    68394   -201840     
  Partials      401      401               

[armenzg]

Very nice PR!