chore(eslint): Enable and mostly auto-fix unicorn/prefer-includes #87674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
changed the title
michellewzhang
approved these changes
Mar 24, 2025
scttcper
approved these changes
Mar 24, 2025
ryan953
commented
Mar 24, 2025
Comment on lines
+255
to
+259
| const priorityTags = isMobilePlatform(project.platform) | ||
| ? MOBILE_TAGS | ||
| : frontend.some(val => val === project?.platform) | ||
| : frontend.includes(project.platform ?? 'other') | ||
| ? FRONTEND_TAGS | ||
| : backend.some(val => val === project?.platform) | ||
| : backend.includes(project.platform ?? 'other') |
Member
Author
There was a problem hiding this comment.
this needed some manual fixing up. I added ?? 'other' in there.
ryan953
commented
Mar 24, 2025
Comment on lines
+302
to
+306
| isMobilePlatform(project.platform) | ||
| ? MOBILE_TAGS | ||
| : frontend.some(val => val === project?.platform) | ||
| : frontend.includes(project.platform ?? 'other') | ||
| ? FRONTEND_TAGS | ||
| : backend.some(val => val === project?.platform) | ||
| : backend.includes(project.platform ?? 'other') |
Member
Author
There was a problem hiding this comment.
this needed some manual fixing up. I added ?? 'other' in there.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.