Skip to content

fix(gettingStarted): trigger project deletion upon Browser "Back" button #87873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
constantinius merged 2 commits into from
Mar 26, 2025
Merged

fix(gettingStarted): trigger project deletion upon Browser "Back" button #87873

constantinius merged 2 commits into from
Mar 26, 2025

Conversation

@constantinius
Copy link
Contributor

@constantinius constantinius commented Mar 25, 2025

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 25, 2025
@constantinius
Copy link
Contributor Author

constantinius commented Mar 25, 2025

Currently the DELETE request gets cancelled for some reason:
Bildschirmfoto 2025-03-25 um 16 58 50

priscilawebdev
priscilawebdev approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@priscilawebdev priscilawebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we should mimic the behaviour in the project install too. thanks for doing that! 🙏

@ArthurKnaus
Copy link
Member

ArthurKnaus commented Mar 26, 2025

Currently the DELETE request gets cancelled for some reason: Bildschirmfoto 2025-03-25 um 16 58 50

@constantinius you will need to pass persistInFlight: true to useApi in this component. Otherwise it cancels requests on component unmount. In the onboarding this does not happen as the URL change still renders the same component -> no unmount -> no request cancelation.

@constantinius constantinius marked this pull request as ready for review March 26, 2025 09:20
@constantinius constantinius enabled auto-merge (squash) March 26, 2025 09:21
@constantinius constantinius merged commit 89630eb into master Mar 26, 2025
40 checks passed
@constantinius constantinius deleted the constantinius/fix/getting-started-back-project-delete branch March 26, 2025 09:29
andrewshie-sentry pushed a commit that referenced this pull request Mar 27, 2025
@constantinius @andrewshie-sentry
fix(gettingStarted): trigger project deletion upon Browser "Back" but…
f8d0a06 
…ton (#87873)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@priscilawebdev priscilawebdev priscilawebdev approved these changes

@ArthurKnaus ArthurKnaus Awaiting requested review from ArthurKnaus

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@constantinius @ArthurKnaus @priscilawebdev