Skip to content

Conversation

@constantinius
Copy link
Contributor

Closes #88066

@constantinius constantinius requested a review from s1gr1d March 27, 2025 11:07
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 27, 2025
@codecov
Copy link

codecov bot commented Mar 27, 2025

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
10033 5 10028 11
View the top 3 failed test(s) by shortest run time
javascript-svelte onboarding docs enables performance setting the tracesSampleRate to 1
Stack Traces | 0.045s run time
Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.

Encountered two children with the same key, `javascript`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omittedthe behavior is unsupported and could change in a future version.
    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at .../react-dom/cjs/react-dom-client.development.js:4923:23
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at warnOnInvalidKey (.../react-dom/cjs/react-dom-client.development.js:4922:13)
    at reconcileChildrenArray (.../react-dom/cjs/react-dom-client.development.js:4991:31)
    at reconcileChildFibersImpl (.../react-dom/cjs/react-dom-client.development.js:5311:30)
    at .../react-dom/cjs/react-dom-client.development.js:5415:33
    at reconcileChildren (.../react-dom/cjs/react-dom-client.development.js:7738:13)
    at beginWork (.../react-dom/cjs/react-dom-client.development.js:9951:13)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at performUnitOfWork (.../react-dom/cjs/react-dom-client.development.js:15052:22)
    at workLoopSync (.../react-dom/cjs/react-dom-client.development.js:14870:41)
    at renderRootSync (.../react-dom/cjs/react-dom-client.development.js:14850:11)
    at performWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:14334:13)
    at performWorkOnRootViaSchedulerTask (.../react-dom/cjs/react-dom-client.development.js:15931:7)
    at flushActQueue (.../react/cjs/react.development.js:862:34)
    at Object.<anonymous>.process.env.NODE_ENV.exports.act (.../react/cjs/react.development.js:1151:10)
    at .../sentry/sentry/node_modules/@.../react/dist/act-compat.js:47:25
    at renderRoot (.../sentry/sentry/node_modules/@.../react/dist/pure.js:188:26)
    at Object.render (.../sentry/sentry/node_modules/@.../react/dist/pure.js:287:10)
    at render (.../js/sentry-test/reactTestingLibrary.tsx:272:28)
    at renderWithOnboardingLayout (.../sentry-test/onboarding/renderWithOnboardingLayout.tsx:41:35)
    at Object.<anonymous> (.../gettingStartedDocs/javascript/svelte.spec.tsx:39:64)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)
    at flushUnexpectedConsoleCalls (.../sentry/sentry/node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../sentry/sentry/node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../sentry/sentry/node_modules/jest-circus/build/run.js:281:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)
javascript-svelte onboarding docs displays sample rates by default
Stack Traces | 0.068s run time
Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.

Encountered two children with the same key, `javascript`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omittedthe behavior is unsupported and could change in a future version.
    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at .../react-dom/cjs/react-dom-client.development.js:4923:23
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at warnOnInvalidKey (.../react-dom/cjs/react-dom-client.development.js:4922:13)
    at reconcileChildrenArray (.../react-dom/cjs/react-dom-client.development.js:4991:31)
    at reconcileChildFibersImpl (.../react-dom/cjs/react-dom-client.development.js:5311:30)
    at .../react-dom/cjs/react-dom-client.development.js:5415:33
    at reconcileChildren (.../react-dom/cjs/react-dom-client.development.js:7738:13)
    at beginWork (.../react-dom/cjs/react-dom-client.development.js:9951:13)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at performUnitOfWork (.../react-dom/cjs/react-dom-client.development.js:15052:22)
    at workLoopSync (.../react-dom/cjs/react-dom-client.development.js:14870:41)
    at renderRootSync (.../react-dom/cjs/react-dom-client.development.js:14850:11)
    at performWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:14334:13)
    at performWorkOnRootViaSchedulerTask (.../react-dom/cjs/react-dom-client.development.js:15931:7)
    at flushActQueue (.../react/cjs/react.development.js:862:34)
    at Object.<anonymous>.process.env.NODE_ENV.exports.act (.../react/cjs/react.development.js:1151:10)
    at .../sentry/sentry/node_modules/@.../react/dist/act-compat.js:47:25
    at renderRoot (.../sentry/sentry/node_modules/@.../react/dist/pure.js:188:26)
    at Object.render (.../sentry/sentry/node_modules/@.../react/dist/pure.js:287:10)
    at render (.../js/sentry-test/reactTestingLibrary.tsx:272:28)
    at renderWithOnboardingLayout (.../sentry-test/onboarding/renderWithOnboardingLayout.tsx:41:35)
    at Object.<anonymous> (.../gettingStartedDocs/javascript/svelte.spec.tsx:31:64)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)
    at flushUnexpectedConsoleCalls (.../sentry/sentry/node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../sentry/sentry/node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../sentry/sentry/node_modules/jest-circus/build/run.js:281:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)
javascript-svelte onboarding docs enables profiling by setting profiling sample rates
Stack Traces | 0.068s run time
Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.

Encountered two children with the same key, `javascript`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omittedthe behavior is unsupported and could change in a future version.
    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at .../react-dom/cjs/react-dom-client.development.js:4923:23
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at warnOnInvalidKey (.../react-dom/cjs/react-dom-client.development.js:4922:13)
    at reconcileChildrenArray (.../react-dom/cjs/react-dom-client.development.js:4991:31)
    at reconcileChildFibersImpl (.../react-dom/cjs/react-dom-client.development.js:5311:30)
    at .../react-dom/cjs/react-dom-client.development.js:5415:33
    at reconcileChildren (.../react-dom/cjs/react-dom-client.development.js:7738:13)
    at beginWork (.../react-dom/cjs/react-dom-client.development.js:9951:13)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at performUnitOfWork (.../react-dom/cjs/react-dom-client.development.js:15052:22)
    at workLoopSync (.../react-dom/cjs/react-dom-client.development.js:14870:41)
    at renderRootSync (.../react-dom/cjs/react-dom-client.development.js:14850:11)
    at performWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:14334:13)
    at performWorkOnRootViaSchedulerTask (.../react-dom/cjs/react-dom-client.development.js:15931:7)
    at flushActQueue (.../react/cjs/react.development.js:862:34)
    at Object.<anonymous>.process.env.NODE_ENV.exports.act (.../react/cjs/react.development.js:1151:10)
    at .../sentry/sentry/node_modules/@.../react/dist/act-compat.js:47:25
    at renderRoot (.../sentry/sentry/node_modules/@.../react/dist/pure.js:188:26)
    at Object.render (.../sentry/sentry/node_modules/@.../react/dist/pure.js:287:10)
    at render (.../js/sentry-test/reactTestingLibrary.tsx:272:28)
    at renderWithOnboardingLayout (.../sentry-test/onboarding/renderWithOnboardingLayout.tsx:41:35)
    at Object.<anonymous> (.../gettingStartedDocs/javascript/svelte.spec.tsx:52:64)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)
    at flushUnexpectedConsoleCalls (.../sentry/sentry/node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../sentry/sentry/node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../sentry/sentry/node_modules/jest-circus/build/run.js:281:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@constantinius constantinius marked this pull request as ready for review March 27, 2025 13:43
@constantinius constantinius requested a review from a team as a code owner March 27, 2025 13:43
@constantinius constantinius requested review from a team and removed request for a team March 27, 2025 17:11
Copy link
Member

@priscilawebdev priscilawebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested everything locally and it looks good to me. Leaving the final approval to @s1gr1d

@constantinius constantinius merged commit 7236488 into master Mar 28, 2025
40 checks passed
@constantinius constantinius deleted the constantinius/feat/getting-started/svelte-v5-fixes branch March 28, 2025 08:49
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Svelte onboarding: configure leads to error

3 participants