🔧 chore(integration slos): fix gitlab check_file slos#88199
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
| ): | ||
| lifecycle.record_halt(e) | ||
| return None | ||
| else: |
Member
There was a problem hiding this comment.
nit: else here is unnecessary.
GabeVillalobos
approved these changes
Apr 1, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
similar to the fix made for `get_blame_for_files`, we record halts for `check_file` as well for the same `ApiRetryError` i also added slo tests for gitlab since they were missing relates to #87785 closes: https://linear.app/getsentry/issue/ECO-369/fix-gitlab-slos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similar to the fix made for
get_blame_for_files, we record halts forcheck_fileas well for the sameApiRetryErrori also added slo tests for gitlab since they were missing
relates to #87785
closes: https://linear.app/getsentry/issue/ECO-369/fix-gitlab-slos