ref(debugger-modal): Introduced content diff slider to the modal#88420
Merged
priscilawebdev merged 15 commits intoApr 3, 2025
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88420 +/- ##
==========================================
- Coverage 87.76% 87.74% -0.03%
==========================================
Files 10033 9999 -34
Lines 567980 565741 -2239
Branches 22273 22155 -118
==========================================
- Hits 498487 496388 -2099
+ Misses 69070 68936 -134
+ Partials 423 417 -6 |
…priscila/ref/debugger-modal/introduce-content-diff-slider
scttcper
reviewed
Apr 1, 2025
| margin-top: -${space(1)}; | ||
| `; | ||
|
|
||
| const DebuggerSectionContainer = styled(Flex)` |
Member
There was a problem hiding this comment.
just put all the styles here instead of mixing styles on top of Flex
Member
Author
There was a problem hiding this comment.
should Flex be used entirely without restyling? Do we have any guidelines on this?
Member
There was a problem hiding this comment.
avoid styling styled components in general
Member
Author
There was a problem hiding this comment.
I understand...just noticed that we have this all over the app. Was this discussed in the TSC? if not, we should :)
…ies.tsx Co-authored-by: Ryan Albrecht <ryan.albrecht@sentry.io>
…priscila/ref/debugger-modal/introduce-content-diff-slider
…thub.com:getsentry/sentry into priscila/feat/components/add-content-diff-slider
…priscila/ref/debugger-modal/introduce-content-diff-slider
Base automatically changed from
priscila/feat/components/add-content-diff-slider
to
master
April 3, 2025 08:12
lforst
approved these changes
Apr 3, 2025
ArthurKnaus
approved these changes
Apr 3, 2025
priscilawebdev
deleted the
priscila/ref/debugger-modal/introduce-content-diff-slider
branch
adrian-codecov
pushed a commit
that referenced
this pull request
Apr 3, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the ContentDiffSlider component within the Debugger Modal.
It reorganizes the content into two distinct sections: "Why Configure Source Maps?" and "Troubleshooting Your Source Maps".
Additionally, unnecessary spaces are removed, and new spaces are added where needed for improved clarity and readability.
closes https://github.com/getsentry/projects/issues/731
Preview
Screen.Recording.2025-04-01.at.12.57.21.mov
Note
I was not able to drag the divider while recording for some reason