fix(span-buffer): Do not flush forever after rebalancing#88784
Merged
Conversation
When rebalancing happens, segments get sharded into different queues than before. Meaning that done_flush_segments tries to delete the "done" key from the wrong queue. Pull through the queue_key to done_flush_segments to fix that.
jan-auer
approved these changes
Apr 4, 2025
github-actions
Bot
added
the
Scope: Backend
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
When rebalancing happens, segments get sharded into different queues than before. Meaning that done_flush_segments tries to delete the "done" key from the wrong queue. Pull through the queue_key to done_flush_segments to fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rebalancing happens, segments get sharded into different queues
than before. Meaning that done_flush_segments tries to delete the "done"
key from the wrong queue. Pull through the queue_key to
done_flush_segments to fix that.