feat(explore): Update get explore queries to return starred position and add sort by most starred option#89034
Merged
edwardgou-sentry merged 5 commits intoApr 9, 2025
Conversation
… most starred option
github-actions
Bot
added
the
Scope: Backend
Contributor
Author
|
moving this back to draft, there's some additional functionality i need to add to address some further feedback |
Contributor
Author
|
Reopened for review. Updated the endpoint to accept sortBy as a list, so that users can select a secondary sort option. |
narsaynorath
approved these changes
Apr 8, 2025
narsaynorath
left a comment
narsaynorath
left a comment
Member
There was a problem hiding this comment.
lgtm, just some small comments
edwardgou-sentry
deleted the
egou/feat/explore-starred-position-and-order
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #89034 +/- ##
===========================================
+ Coverage 32.96% 87.71% +54.74%
===========================================
Files 8524 10091 +1567
Lines 476100 571234 +95134
Branches 22432 22432
===========================================
+ Hits 156946 501050 +344104
+ Misses 318711 69741 -248970
Partials 443 443 |
Christinarlong
pushed a commit
that referenced
this pull request
Apr 10, 2025
…and add sort by most starred option (#89034) - Updates the `GET` explore saved queries endpoint to also return the starred position of each query (in the serializer). - Updates the endpoint to return queries in order of their starred position when `starred_queries` is true. - Adds a `mostStarred` sort by option that returns queries in order of most starred. - Updates endpoint sort by query param to be a list, to allow secondary sort selection by the user.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
…and add sort by most starred option (#89034) - Updates the `GET` explore saved queries endpoint to also return the starred position of each query (in the serializer). - Updates the endpoint to return queries in order of their starred position when `starred_queries` is true. - Adds a `mostStarred` sort by option that returns queries in order of most starred. - Updates endpoint sort by query param to be a list, to allow secondary sort selection by the user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GETexplore saved queries endpoint to also return the starred position of each query (in the serializer).starred_queriesis true.mostStarredsort by option that returns queries in order of most starred.