🔧 chore(aci): organization action handlers into integrations directory#89140
Merged
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #89140 +/- ##
===========================================
+ Coverage 61.71% 87.69% +25.97%
===========================================
Files 10092 10107 +15
Lines 571118 571266 +148
Branches 22447 22447
===========================================
+ Hits 352473 500979 +148506
+ Misses 218237 69879 -148358
Partials 408 408 |
GabeVillalobos
approved these changes
Apr 9, 2025
GabeVillalobos
left a comment
Member
There was a problem hiding this comment.
Colocating the handlers with their integration code makes sense to me. And we're sure this addresses the registration issue globally?
| from sentry.rules import rules | ||
|
|
||
| from .actions.create_ticket import GitHubEnterpriseCreateTicketAction | ||
| from .handlers import GithubEnterpriseActionHandler # noqa: F401,F403 |
Member
There was a problem hiding this comment.
what are these specific qa things we're disabling?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr reorganizes the action handler folder structure.
i was running into problems with circular dependencies and not registering the handlers correctly. this pr fixes it by moving all action handlers out of the workflow_engine repo.
we follow the
src/integrations/handlers/folder structure which prevents all circular imports.i also verified that all the handlers are properly registered in the app:
the folder structure looks something like: