fix(aci): Rename MetricAlertFire to MetricIssue #89896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
snigdhas
commented
Apr 18, 2025
src/sentry/incidents/grouptype.py
Outdated
Comment on lines
112
to
114
| # This needs to be removed once the import in getsentry is updated to use MetricIssue | ||
| class MetricAlertFire: | ||
| pass |
snigdhas
force-pushed
the
snigdha/rename-group-type
branch
from
1db08c3 to
0ce46f9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #89896 +/- ##
==========================================
+ Coverage 87.72% 87.77% +0.04%
==========================================
Files 10239 10226 -13
Lines 577356 576196 -1160
Branches 22696 22562 -134
==========================================
- Hits 506502 505749 -753
+ Misses 70411 70016 -395
+ Partials 443 431 -12 |
snigdhas
added a commit
that referenced
this pull request
Apr 21, 2025
We're renaming `MetricAlertFire` to `MetricIssue` ([PR](#89896)). To do so, we need to drop existing detectors that use the `metric_alert_fire` slug. There's ~230 rows that match that filter and the table has ~3k rows. All the rows in the table were written during a test of the dual write and are safe to drop as they'll be rewritten again once the flag is on. I've marked this as post-deploy but it probably doesn't need to be.
snigdhas
added a commit
that referenced
this pull request
Apr 22, 2025
Migration has been run, test will not be runnable once #89896 lands
mifu67
approved these changes
Apr 22, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
We're renaming `MetricAlertFire` to `MetricIssue` ([PR](#89896)). To do so, we need to drop existing detectors that use the `metric_alert_fire` slug. There's ~230 rows that match that filter and the table has ~3k rows. All the rows in the table were written during a test of the dual write and are safe to drop as they'll be rewritten again once the flag is on. I've marked this as post-deploy but it probably doesn't need to be.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
Migration has been run, test will not be runnable once #89896 lands
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're renaming
MetricAlertFiretoMetricIssueand changing the group type slug frommetric_alert_firetometric_issue. This change is safe to land once this migration drops all the existing detector rows that usemetric_alert_fire.I've left a skeleton class def with the slug to keep getsentry tests passing. The corresponding getsentry PR can land after this one, and then I'll remove the class in a followup.