fix(aci): Drop metric_alert_fire detectors

[snigdhas]

We're renaming MetricAlertFire to MetricIssue (PR). To do so, we need to drop existing detectors that use the metric_alert_fire slug. There's ~230 rows that match that filter and the table has ~3k rows. All the rows in the table were written during a test of the dual write and are safe to drop as they'll be rewritten again once the flag is on. I've marked this as post-deploy but it probably doesn't need to be.

[github-actions]

This PR has a migration; here is the generated SQL for src/sentry/workflow_engine/migrations/0046_drop_metric_alert_fire_detectors.py ()

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #89924       +/-   ##
===========================================
+ Coverage   74.82%   87.74%   +12.91%     
===========================================
  Files       10201    10216       +15     
  Lines      575312   576344     +1032     
  Branches    22655    22655               
===========================================
+ Hits       430500   505713    +75213     
+ Misses     144378    70197    -74181     
  Partials      434      434               

[mifu67]

If we're dropping the detectors, we probably also want to drop the dual written metric alert workflows.

[saponifi3d]

lgtm - cc @mifu67 to make sure the rollout flag is at 0 (and that we'll want to keep it at 0 until we can update to metric_issue)

also +1 to michelle's callout abuot dropping the workflows -- probably easier to do before we drop the detectors to use the DetectorWorkflow lookups.

[wedamija]

lgtm, is there any way that more of these will get created in between running this and merging your other pr?

[mifu67]

@wedamija dual write is currently turned off (rollout set to 0%), so there shouldn't be any new detectors created with the old slug.

[sentry]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ ProgrammingError: UndefinedTable('relation "workflow_engine_workflow" does not exist\nLINE 1: ..., "workflow_engine_workflow"."owner_user_id" FROM "workflow_...\n ^\n') sentry.workflow_engine.migrations.0046_drop_met... View Issue

_{Did you find this useful? React with a 👍 or 👎}