fix(feedback): fix typing for shims from v2 to v1 #89949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #89949 +/- ##
=======================================
Coverage 87.64% 87.64%
=======================================
Files 10250 10251 +1
Lines 577029 577050 +21
Branches 22719 22719
=======================================
+ Hits 505725 505756 +31
+ Misses 70861 70851 -10
Partials 443 443 |
Comment on lines
-139
to
-140
| if event_data.get("dist") is not None: | ||
| del event_data["dist"] |
Member
Author
There was a problem hiding this comment.
This code wasn't doing anything.. since we never set dist in ret_event, and don't use the original event after this fx is called
michellewzhang
approved these changes
Apr 18, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
Follow-up on #89685. Fixes [SENTRY-3SEX](https://sentry.sentry.io/issues/6551468609/events/9a88f59af64d4f86bddf42060cdff0d9/) Fixes [SENTRY-3SEZ](https://sentry.sentry.io/issues/6551532041/events/bd020dada1a74f1ba96faa07c33df30c/) Fixes [SENTRY-3SEY](https://sentry.sentry.io/issues/6551484362/events/42136852328a4acdb6f21922bd6425af/) Only the message/comments field is required, so we need to handle missing name or email. Also event timestamp is a ISO str. Also adds better typing to `save_userreport` and cleans up the event formatting code in `create_feedback` a bit. Functionality is the same, except now we'll always include the `user.email` context/tag, defaulting to empty str `""`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #89685.
Fixes SENTRY-3SEX
Fixes SENTRY-3SEZ
Fixes SENTRY-3SEY
Only the message/comments field is required, so we need to handle missing name or email. Also event timestamp is a ISO str.
Also adds better typing to
save_userreportand cleans up the event formatting code increate_feedbacka bit. Functionality is the same, except now we'll always include theuser.emailcontext/tag, defaulting to empty str""