-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(feedback): shim feedback v2 to postgres so they can be queried by group_id #89685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #89685 +/- ##
========================================
Coverage 85.27% 85.27%
========================================
Files 10175 10186 +11
Lines 574316 575110 +794
Branches 22625 22625
========================================
+ Hits 489739 490453 +714
- Misses 84030 84110 +80
Partials 547 547 |
ryan953
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems reasonable to me. but i would have a hard time to know what, if anything, is missing
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Follow-up on #89685. Fixes [SENTRY-3SEX](https://sentry.sentry.io/issues/6551468609/events/9a88f59af64d4f86bddf42060cdff0d9/) Fixes [SENTRY-3SEZ](https://sentry.sentry.io/issues/6551532041/events/bd020dada1a74f1ba96faa07c33df30c/) Fixes [SENTRY-3SEY](https://sentry.sentry.io/issues/6551484362/events/42136852328a4acdb6f21922bd6425af/) Only the message/comments field is required, so we need to handle missing name or email. Also event timestamp is a ISO str. Also adds better typing to `save_userreport` and cleans up the event formatting code in `create_feedback` a bit. Functionality is the same, except now we'll always include the `user.email` context/tag, defaulting to empty str `""`
Fixes SENTRY-3SFQ Followup to #89685 Improves the test coverage so we assert a UR is actually saved, instead of asserting the arguments to `save_userreport`.
Follow-up on #89685. Fixes [SENTRY-3SEX](https://sentry.sentry.io/issues/6551468609/events/9a88f59af64d4f86bddf42060cdff0d9/) Fixes [SENTRY-3SEZ](https://sentry.sentry.io/issues/6551532041/events/bd020dada1a74f1ba96faa07c33df30c/) Fixes [SENTRY-3SEY](https://sentry.sentry.io/issues/6551484362/events/42136852328a4acdb6f21922bd6425af/) Only the message/comments field is required, so we need to handle missing name or email. Also event timestamp is a ISO str. Also adds better typing to `save_userreport` and cleans up the event formatting code in `create_feedback` a bit. Functionality is the same, except now we'll always include the `user.email` context/tag, defaulting to empty str `""`
Fixes SENTRY-3SFQ Followup to #89685 Improves the test coverage so we assert a UR is actually saved, instead of asserting the arguments to `save_userreport`.
Closes #89700
Doc describing the problem and changes: https://www.notion.so/sentry/UF-Ingest-Update-April-2025-1d78b10e4b5d80f08350fa1fbf204b24?pvs=4
Also adds
userreport.pytest coverage for the shim cases.Testing Notes / Expected Behavior
Submit a feedback with the JS SDK's
captureFeedbackfunction. Be sure to include anassociatedEventIdcorresponding to an error event in the same project.The feedback should show up in Sentry
/feedback/page in a few seconds, at most 30s.Open the feedback and find the "Linked Error" section. Click on it to visit the issue/event detail.
The feedback email, name, and message should be visible in the "User Feedback" section, and match what you see in
/feedback/.No duplicate feedback should be seen in
/feedback/(wait 15min to confirm this)Widget feedbacks shouldn't break