ref(distributions): Refactor fetching flags and their suspect scores #89962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
aliu39
reviewed
Apr 19, 2025
static/app/views/issueDetails/groupFeatureFlags/useGroupFlagDrawerData.tsx
Outdated
Show resolved
Hide resolved
static/app/views/issueDetails/groupFeatureFlags/useGroupFlagDrawerData.tsx
Outdated
Show resolved
Hide resolved
static/app/views/issueDetails/groupFeatureFlags/useGroupFlagDrawerData.tsx
Outdated
Show resolved
Hide resolved
static/app/views/issueDetails/groupFeatureFlags/useGroupFlagDrawerData.tsx
Show resolved
Hide resolved
static/app/views/issueDetails/groupFeatureFlags/flagDrawerContent.tsx
Outdated
Show resolved
Hide resolved
aliu39
approved these changes
Apr 21, 2025
ryan953
added a commit
that referenced
this pull request
Apr 22, 2025
… Distributions flyout (#89978) **Sorting Options** | Tags | Flags | | --- | --- | |  |  **Flags UI** This is a partial representation of the following cases: - Feature `feature-flag-suspect-flags` on/off -> controls the yellow table - Feature `suspect-scores-sandbox-ui` on/off -> controls the checkbox - LocalStorage `flag-drawer-show-suspicion-scores` on/off -> controls if we see all the debug info & number input | Case | User Facing | Internal Debugging | | --- | --- | --- | | No flags enabled |  | | Sus Table Empty |  | | Sus Table w/ Data |  |  | Sus Table w/ debugging | |  Depends on #89962
billyvg
pushed a commit
that referenced
this pull request
Apr 22, 2025
… Distributions flyout (#89978) **Sorting Options** | Tags | Flags | | --- | --- | |  |  **Flags UI** This is a partial representation of the following cases: - Feature `feature-flag-suspect-flags` on/off -> controls the yellow table - Feature `suspect-scores-sandbox-ui` on/off -> controls the checkbox - LocalStorage `flag-drawer-show-suspicion-scores` on/off -> controls if we see all the debug info & number input | Case | User Facing | Internal Debugging | | --- | --- | --- | | No flags enabled |  | | Sus Table Empty |  | | Sus Table w/ Data |  |  | Sus Table w/ debugging | |  Depends on #89962
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
…89962) This is in preparation of the new suspect flags table. The new table will call `useFlagDrawerData()` and then show any flags that are over a specific threshold. But that table and all the ui stuff is a bunch of code, so i split this off separately. Once the new table starts calling `useFlagDrawerData` then there'll be two spots that will share the same caches for `useGroupFeatureFlags` and `useGroupSuspectFlagScores`; but all the `useMemo` calls in here will double up the memory footprint; optimizing for sharing code over memory i guess.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
… Distributions flyout (#89978) **Sorting Options** | Tags | Flags | | --- | --- | |  |  **Flags UI** This is a partial representation of the following cases: - Feature `feature-flag-suspect-flags` on/off -> controls the yellow table - Feature `suspect-scores-sandbox-ui` on/off -> controls the checkbox - LocalStorage `flag-drawer-show-suspicion-scores` on/off -> controls if we see all the debug info & number input | Case | User Facing | Internal Debugging | | --- | --- | --- | | No flags enabled |  | | Sus Table Empty |  | | Sus Table w/ Data |  |  | Sus Table w/ debugging | |  Depends on #89962
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation of the new suspect flags table. The new table will call
useFlagDrawerData()and then show any flags that are over a specific threshold. But that table and all the ui stuff is a bunch of code, so i split this off separately.Once the new table starts calling
useFlagDrawerDatathen there'll be two spots that will share the same caches foruseGroupFeatureFlagsanduseGroupSuspectFlagScores; but all theuseMemocalls in here will double up the memory footprint; optimizing for sharing code over memory i guess.