feat(feature flags): Add basic Suspect Flag table to the Feature Flag Distributions flyout #89978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
force-pushed
the
ryan953/suspect-flags-table-2
branch
2 times, most recently
from
2ba549f to
9d644cf
Compare
… Distributions flyout
ryan953
force-pushed
the
ryan953/suspect-flags-table-2
branch
from
9d644cf to
9888259
Compare
aliu39
reviewed
Apr 22, 2025
| {susFlags.map(flag => { | ||
| const topValue = flag.topValues[0]; | ||
|
|
||
| const projPercentage = Math.round((flag.suspect.baselinePercent ?? 0) * 100); |
Member
There was a problem hiding this comment.
baselinePercent is the percent true in the project. I'd do something like topValue.value == 'true' ? baselinePercent : 100 - baselinePercent.
Or, maybe better, make it so we always show the % true instead of the topValue
aliu39
approved these changes
Apr 22, 2025
billyvg
pushed a commit
that referenced
this pull request
Apr 22, 2025
… Distributions flyout (#89978) **Sorting Options** | Tags | Flags | | --- | --- | |  |  **Flags UI** This is a partial representation of the following cases: - Feature `feature-flag-suspect-flags` on/off -> controls the yellow table - Feature `suspect-scores-sandbox-ui` on/off -> controls the checkbox - LocalStorage `flag-drawer-show-suspicion-scores` on/off -> controls if we see all the debug info & number input | Case | User Facing | Internal Debugging | | --- | --- | --- | | No flags enabled |  | | Sus Table Empty |  | | Sus Table w/ Data |  |  | Sus Table w/ debugging | |  Depends on #89962
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
… Distributions flyout (#89978) **Sorting Options** | Tags | Flags | | --- | --- | |  |  **Flags UI** This is a partial representation of the following cases: - Feature `feature-flag-suspect-flags` on/off -> controls the yellow table - Feature `suspect-scores-sandbox-ui` on/off -> controls the checkbox - LocalStorage `flag-drawer-show-suspicion-scores` on/off -> controls if we see all the debug info & number input | Case | User Facing | Internal Debugging | | --- | --- | --- | | No flags enabled |  | | Sus Table Empty |  | | Sus Table w/ Data |  |  | Sus Table w/ debugging | |  Depends on #89962
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorting Options
Flags UI
This is a partial representation of the following cases:
feature-flag-suspect-flagson/off -> controls the yellow tablesuspect-scores-sandbox-uion/off -> controls the checkboxflag-drawer-show-suspicion-scoreson/off -> controls if we see all the debug info & number inputDepends on #89962