Skip to content

ref(issue-taxonomy): Cleanup unnecessary references to cron and uptime issue catgegories #89986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malwilley merged 2 commits into from
Apr 21, 2025
Merged

ref(issue-taxonomy): Cleanup unnecessary references to cron and uptime issue catgegories #89986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97828ec
ref(issue-taxonomy): Cleanup unnecssary references to cron and uptime…
malwilley Apr 21, 2025
a404a90
Fix test
malwilley Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion static/app/views/alerts/rules/uptime/details.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ describe('UptimeAlertDetails', function () {
body: [],
});
MockApiClient.addMockResponse({
url: `/organizations/${organization.slug}/issues/?limit=1&project=${project.id}&query=issue.category%3Auptime%20tags%5Buptime_rule%5D%3A1`,
url: `/organizations/${organization.slug}/issues/?limit=1&project=${project.id}&query=issue.type%3Auptime_domain_failure%20tags%5Buptime_rule%5D%3A1`,
body: [],
});
MockApiClient.addMockResponse({
Expand Down
4 changes: 2 additions & 2 deletions static/app/views/alerts/rules/uptime/uptimeIssues.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import GroupList from 'sentry/components/issues/groupList';
import Panel from 'sentry/components/panels/panel';
import PanelBody from 'sentry/components/panels/panelBody';
import {t} from 'sentry/locale';
import {IssueCategory} from 'sentry/types/group';
import {IssueType} from 'sentry/types/group';
import type {Project} from 'sentry/types/project';

interface Props {
Expand All @@ -13,7 +13,7 @@ interface Props {

export function UptimeIssues({project, ruleId}: Props) {
// TODO(davidenwang): Replace this with an actual query for the specific uptime alert rule
const query = `issue.category:${IssueCategory.UPTIME} tags[uptime_rule]:${ruleId}`;
const query = `issue.type:${IssueType.UPTIME_DOMAIN_FAILURE} tags[uptime_rule]:${ruleId}`;

const emptyMessage = () => {
return (
Expand Down
6 changes: 3 additions & 3 deletions static/app/views/issueDetails/groupEventDetails/groupEventDetailsContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ import {space} from 'sentry/styles/space';
import type {Entry, EntryException, Event, EventTransaction} from 'sentry/types/event';
import {EntryType, EventOrGroupType} from 'sentry/types/event';
import type {Group} from 'sentry/types/group';
import {IssueCategory} from 'sentry/types/group';
import {IssueType} from 'sentry/types/group';
import type {Project} from 'sentry/types/project';
import {defined} from 'sentry/utils';
import {getConfigForIssueType} from 'sentry/utils/issueTypeConfig';
Expand Down Expand Up @@ -215,10 +215,10 @@ export function EventDetailsContent({
}) ? (
<LazyLoad LazyComponent={LLMMonitoringSection} event={event} />
) : null}
{!hasStreamlinedUI && group.issueCategory === IssueCategory.UPTIME && (
{!hasStreamlinedUI && group.issueType === IssueType.UPTIME_DOMAIN_FAILURE && (
<UptimeDataSection event={event} project={project} group={group} />
)}
{!hasStreamlinedUI && group.issueCategory === IssueCategory.CRON && (
{!hasStreamlinedUI && group.issueType === IssueType.MONITOR_CHECK_IN_FAILURE && (
<CronTimelineSection
event={event}
organization={organization}
Expand Down
Loading