feat(chunk upload): Allow disabling compression per org#90038
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #90038 +/- ##
==========================================
+ Coverage 85.11% 87.63% +2.52%
==========================================
Files 10246 10280 +34
Lines 577542 577659 +117
Branches 22709 22731 +22
==========================================
+ Hits 491587 506260 +14673
+ Misses 85512 70956 -14556
Partials 443 443 |
szokeasaurusrex
approved these changes
Apr 22, 2025
szokeasaurusrex
left a comment
Member
There was a problem hiding this comment.
Looks good from CLI perspective ✅
Tbh I am not super familiar with how this options stuff works, so I'd recommend a second person more familiar with that part of the codebase also approves this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A backend-side alternative to getsentry/sentry-cli#2468.
Background: Some customers report being unable to upload debug files with
sentry-clibecause of a 503 error in the chunk upload endpoint. We managed to fix this in one specific case by turning off chunk compression insentry-cli, but it's unclear whether that is a general fix or why it would make a difference. Therefore we would like to make this option available to those customers so that they can (hopefully) upload their debug files and we can determine whether the compression has anything to do with it. Rather than modifysentry-clito allow uncompressed uploads, the much simpler change is to have the server tellsentry-clinot to use compression for specific orgs.ref INGEST-132