Skip to content

feat(chunk upload): Allow disabling compression per org#90038

Merged
loewenheim merged 3 commits into
masterfrom
feat/chunk-upload-no-compression
Apr 23, 2025
Merged

feat(chunk upload): Allow disabling compression per org#90038
loewenheim merged 3 commits into
masterfrom
feat/chunk-upload-no-compression

Conversation

@loewenheim

Copy link
Copy Markdown
Contributor

A backend-side alternative to getsentry/sentry-cli#2468.

Background: Some customers report being unable to upload debug files with sentry-cli because of a 503 error in the chunk upload endpoint. We managed to fix this in one specific case by turning off chunk compression in sentry-cli, but it's unclear whether that is a general fix or why it would make a difference. Therefore we would like to make this option available to those customers so that they can (hopefully) upload their debug files and we can determine whether the compression has anything to do with it. Rather than modify sentry-cli to allow uncompressed uploads, the much simpler change is to have the server tell sentry-cli not to use compression for specific orgs.

ref INGEST-132

@codecov

codecov Bot commented Apr 22, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #90038      +/-   ##
==========================================
+ Coverage   85.11%   87.63%   +2.52%     
==========================================
  Files       10246    10280      +34     
  Lines      577542   577659     +117     
  Branches    22709    22731      +22     
==========================================
+ Hits       491587   506260   +14673     
+ Misses      85512    70956   -14556     
  Partials      443      443              

@szokeasaurusrex szokeasaurusrex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from CLI perspective ✅

Tbh I am not super familiar with how this options stuff works, so I'd recommend a second person more familiar with that part of the codebase also approves this PR

@loewenheim loewenheim enabled auto-merge (squash) April 23, 2025 06:49
@loewenheim loewenheim merged commit d43d79e into master Apr 23, 2025
@loewenheim loewenheim deleted the feat/chunk-upload-no-compression branch April 23, 2025 07:15
@github-actions github-actions Bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants