Skip to content

Conversation

@vgrozdanic
Copy link
Member

After rolling out to 100% last week, we can now safely remove old code which is no longer used/

Continuation of https://github.com/getsentry/sentry-options-automator/pull/3597 and #89265

@vgrozdanic vgrozdanic requested a review from a team April 22, 2025 10:13
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 22, 2025
Copy link
Member

@shellmayr shellmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #90042      +/-   ##
==========================================
+ Coverage   85.12%   87.62%   +2.49%     
==========================================
  Files       10271    10273       +2     
  Lines      577639   577638       -1     
  Branches    22763    22763              
==========================================
+ Hits       491732   506147   +14415     
+ Misses      85464    71048   -14416     
  Partials      443      443              

@vgrozdanic vgrozdanic enabled auto-merge (squash) April 22, 2025 11:02
@vgrozdanic vgrozdanic merged commit b542eed into master Apr 22, 2025
64 checks passed
@vgrozdanic vgrozdanic deleted the vgrozdanic/clean-up-enviornment-project-refactor branch April 22, 2025 12:30
andrewshie-sentry pushed a commit that referenced this pull request Apr 22, 2025
…90042)

After rolling out to 100% last week, we can now safely remove old code
which is no longer used/

Continuation of
getsentry/sentry-options-automator#3597 and
#89265
vgrozdanic added a commit that referenced this pull request Apr 23, 2025
Time to fully clean up after the refactor.

Refactored code, and the only usage of the option was deployed in
#90042, also an option from
option automator has been cleaned in
getsentry/sentry-options-automator#3621.
@sentry
Copy link

sentry bot commented May 3, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ IntegrityError: insert or update on table "sentry_environmentproject" violates foreign key constraint "project_id_refs_id_cf2e01df" sentry.tasks.store.save_event_transaction View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants