ref(feedback): display crash report icon for django endpoint feedbacks#90133
ref(feedback): display crash report icon for django endpoint feedbacks#90133
Conversation
| export const CRASH_REPORT_SOURCES: string[] = [ | ||
| 'user_report_envelope', | ||
| 'user_report_sentry_django_endpoint', | ||
| 'crash_report_embed_form', | ||
| ] as const; |
There was a problem hiding this comment.
It's a bit unusual to have non-types in a types.tsx, but it's not that much different if this were an enum
There was a problem hiding this comment.
the file could be renamed to utils.tsx but that might be worse as it's already in the utils folder 💀
There was a problem hiding this comment.
types.tsx & utils.tsx & consts.tsx & index.tsx are all just bad names in general... grab bags of stuff :(
hasLinkedError.tsx could be a good name for something like this:
const CRASH_REPORT_SOURCES: string[] = [
'user_report_envelope',
'user_report_sentry_django_endpoint',
'crash_report_embed_form',
] as const;
export default function hasLinkedError(item: FeedbackIssueListItem): boolean {
return CRASH_REPORT_SOURCES.includes(
item.metadata.source ?? ''
);
}
but it's a drop in the ocean to change things here
There was a problem hiding this comment.
I like the hasLinkedError.tsx file idea!
This comment was marked as outdated.
This comment was marked as outdated.
|
I realized with the capability of linking errors in the new feedback API, this icon won't show up for that source. The most accurate fix is to render it conditionally when |
#90133) Missed a source here for displaying the red 💀 symbol in feedback list. This source is still used, w/5.7k last month
Missed a source here for displaying the red 💀 symbol in feedback list. This source is still used, w/5.7k last month