-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
ref(uptime): Read uptime_status from uptime_subscription #90434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
evanpurkhiser
merged 1 commit into
master
from
evanpurkhiser/ref-uptime-read-uptime-status-from-uptime-subscription
May 1, 2025
Merged
ref(uptime): Read uptime_status from uptime_subscription #90434
evanpurkhiser
merged 1 commit into
master
from
evanpurkhiser/ref-uptime-read-uptime-status-from-uptime-subscription
May 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1950d2 to
c143d74
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #90434 +/- ##
===========================================
+ Coverage 42.26% 87.80% +45.53%
===========================================
Files 10255 10281 +26
Lines 582397 583445 +1048
Branches 22579 22579
===========================================
+ Hits 246168 512281 +266113
+ Misses 335798 70733 -265065
Partials 431 431 |
c143d74 to
beb211c
Compare
Member
Author
|
Verified all the status's match using this query select
sub.id as sub_id,
sub.uptime_status as sub_uptime_status,
sub.uptime_status_update_date :: text as sub_uptime_status_update_date,
pus.uptime_status as pus_uptime_status,
pus.uptime_status_update_date :: text as pus_uptime_status_update_date
from
uptime_uptimesubscription sub
join uptime_projectuptimesubscription pus on sub.id = pus.uptime_subscription_id
where
-- Find mismatched uptime_status
(
sub.uptime_status != pus.uptime_status
-- Trim off the minute, we were dual writing slightly different values due to two calls to `timezone.now()`
or date_trunc('minute', sub.uptime_status_update_date) != date_trunc('minute', pus.uptime_status_update_date)
) |
wedamija
approved these changes
May 1, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
Switches reading of `uptime_status` (and `uptime_status_update_date`) to the `uptime_subscription` model. We'll need this to migrate to reading from detectors (and implementing the detector handler)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches reading of
uptime_status(anduptime_status_update_date) tothe
uptime_subscriptionmodel.We'll need this to migrate to reading from detectors (and implementing
the detector handler)