ref(✂️): move code into stories that's only used in stories #90463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to analyze which code is unused outside of stories and tests, we can't create random files that are used in stories or tests. Instead, we need to define clear structures (e.g. `testUtils` or `__stories__ directories`), or inline usages.
TkDodo
changed the title
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #90463 +/- ##
==========================================
- Coverage 87.86% 87.82% -0.05%
==========================================
Files 10276 10270 -6
Lines 581600 579632 -1968
Branches 22633 22633
==========================================
- Hits 511046 509034 -2012
- Misses 70120 70164 +44
Partials 434 434 |
gggritso
approved these changes
Apr 28, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
To be able to analyze which code is unused outside of stories and tests, we can't create random files that are used in stories or tests. Instead, we need to define clear structures (e.g. `testUtils` or `__stories__` directories), or inline usages.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to analyze which code is unused outside of stories and tests, we can't create random files that are used in stories or tests. Instead, we need to define clear structures (e.g.
testUtilsor__stories__directories), or inline usages.