ref: convert AuthTokenType to a StrEnum#90519
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
asottile-sentry
force-pushed
the
asottile-auth-token-type-str-enum
branch
from
a62ff34 to
7cad8f1
Compare
joshuarli
approved these changes
Apr 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #90519 +/- ##
===========================================
+ Coverage 42.20% 87.75% +45.54%
===========================================
Files 10233 10259 +26
Lines 579053 580111 +1058
Branches 22629 22629
===========================================
+ Hits 244394 509068 +264674
+ Misses 334216 70600 -263616
Partials 443 443 |
TextChoices has some weird typing interaction with _StrPromise and doesn't really buy us much over a normal enum if we aren't using custom labels
asottile-sentry
force-pushed
the
asottile-auth-token-type-str-enum
branch
from
7cad8f1 to
d947d33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TextChoices has some weird typing interaction with _StrPromise and doesn't really buy us much over a normal enum if we aren't using custom labels