feat(issue-taxonomy): Update taxonomy labels #90797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
MichaelSun48
approved these changes
May 1, 2025
static/app/routes.tsx
Outdated
| <Route | ||
| path="metrics/" | ||
| component={make(() => import('sentry/views/issueList/pages/metrics'))} | ||
| path="regressions/" |
Contributor
There was a problem hiding this comment.
could you use the ISSUE_TAXONOMY_CONFIG[...].label here?
Contributor
There was a problem hiding this comment.
could also just map the ISSUE_TAXONOMY_CONFIG list to route components
(so its more convenient to update when we inevitably change these again)
Member
Author
There was a problem hiding this comment.
Ah yes I can!
I actually tried to make the routes dynamic, but I ran into an issue with lazy loading not caching properly since I needed to send a prop in so that the component would know what kind of taxonomy it was. Oh well, probably not worth the effort
|
❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format. |
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the taxonomy labels after receiving feedback on the initial names. Followup work with update some category labels as well.
Created a config file to draw from since the values are being used in a few places.