ref(tsc): convert RelocationArtifactDetails to FC #90798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
|
❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format. |
michellewzhang
approved these changes
May 1, 2025
scttcper
reviewed
May 1, 2025
Comment on lines
+16
to
+21
| const {artifactKind, fileName, regionName, relocationUuid} = useParams<{ | ||
| artifactKind: string; | ||
| fileName: string; | ||
| regionName: string; | ||
| relocationUuid: string; | ||
| }>(); |
Member
There was a problem hiding this comment.
We have a Region type in `app/types/system' 🤷
Member
There was a problem hiding this comment.
eh i'm not sure that makes sense to use here
scttcper
approved these changes
May 1, 2025
markstory
approved these changes
May 2, 2025
Comment on lines
+16
to
+21
| const {artifactKind, fileName, regionName, relocationUuid} = useParams<{ | ||
| artifactKind: string; | ||
| fileName: string; | ||
| regionName: string; | ||
| relocationUuid: string; | ||
| }>(); |
Member
There was a problem hiding this comment.
We have a Region type in `app/types/system' 🤷
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/getsentry/frontend-tsc/issues/2