Skip to content

feat(insights): set sampling mode widget queries #90821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

feat(insights): set sampling mode widget queries #90821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions static/app/views/performance/landing/widgets/widgets/lineChartListWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ import {
TOTAL_EXPANDABLE_ROWS_HEIGHT,
} from 'sentry/views/performance/landing/widgets/utils';
import {PerformanceWidgetSetting} from 'sentry/views/performance/landing/widgets/widgetDefinitions';
import {EAP_QUERY_PARAMS} from 'sentry/views/performance/landing/widgets/widgets/settings';
import {transactionSummaryRouteWithQuery} from 'sentry/views/performance/transactionSummary/utils';
import {
createUnnamedTransactionsDiscoverTarget,
Expand Down Expand Up @@ -117,11 +118,11 @@ export function LineChartListWidget(props: PerformanceWidgetProps) {
const metricsDataset = useEap ? DiscoverDatasets.SPANS_EAP : DiscoverDatasets.METRICS;

const spanQueryParams: Record<string, string> = useEap
? {useRpc: '1', dataset: DiscoverDatasets.SPANS_EAP}
? {...EAP_QUERY_PARAMS}
: {dataset: DiscoverDatasets.SPANS_METRICS};

const metricsQueryParams: Record<string, string> = useEap
? {useRpc: '1', dataset: DiscoverDatasets.SPANS_EAP}
? {...EAP_QUERY_PARAMS}
: {dataset: DiscoverDatasets.METRICS};

let emptyComponent: any;
Expand Down
3 changes: 2 additions & 1 deletion static/app/views/performance/landing/widgets/widgets/mobileReleaseComparisonListWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ import {
TOTAL_EXPANDABLE_ROWS_HEIGHT,
} from 'sentry/views/performance/landing/widgets/utils';
import {PerformanceWidgetSetting} from 'sentry/views/performance/landing/widgets/widgetDefinitions';
import {EAP_QUERY_PARAMS} from 'sentry/views/performance/landing/widgets/widgets/settings';
import {Subtitle} from 'sentry/views/profiling/landing/styles';
import {RightAlignedCell} from 'sentry/views/replays/deadRageClick/deadRageSelectorCards';

Expand Down Expand Up @@ -119,7 +120,7 @@ function MobileReleaseComparisonListWidget(props: PerformanceWidgetProps) {
: DiscoverDatasets.SPANS_METRICS;

const queryParams: Record<string, string> = useEap
? {useRpc: '1', dataset: DiscoverDatasets.SPANS_EAP}
? {...EAP_QUERY_PARAMS}
: {dataset: DiscoverDatasets.SPANS_METRICS};

const segmentOp = useEap ? 'span.op' : 'transaction.op';
Expand Down
7 changes: 7 additions & 0 deletions static/app/views/performance/landing/widgets/widgets/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import {DiscoverDatasets} from 'sentry/utils/discover/types';
import {DEFAULT_SAMPLING_MODE} from 'sentry/views/insights/common/queries/useDiscover';

export const EAP_QUERY_PARAMS = {
dataset: DiscoverDatasets.SPANS_EAP,
sampling: DEFAULT_SAMPLING_MODE,
};
7 changes: 5 additions & 2 deletions static/app/views/performance/landing/widgets/widgets/singleFieldAreaWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {t} from 'sentry/locale';
import {axisLabelFormatter} from 'sentry/utils/discover/charts';
import DiscoverQuery from 'sentry/utils/discover/discoverQuery';
import {aggregateOutputType} from 'sentry/utils/discover/fields';
import {DiscoverDatasets} from 'sentry/utils/discover/types';
import type {Transform} from 'sentry/utils/performance/contexts/genericQueryBatcher';
import {QueryBatchNode} from 'sentry/utils/performance/contexts/genericQueryBatcher';
import {useMEPSettingContext} from 'sentry/utils/performance/contexts/metricsEnhancedSetting';
Expand All @@ -30,6 +29,7 @@ import {
getMEPQueryParams,
QUERY_LIMIT_PARAM,
} from 'sentry/views/performance/landing/widgets/utils';
import {EAP_QUERY_PARAMS} from 'sentry/views/performance/landing/widgets/widgets/settings';

type DataType = {
chart: WidgetDataResult & ReturnType<typeof transformEventsRequestToArea>;
Expand All @@ -45,7 +45,10 @@ export function SingleFieldAreaWidget(props: PerformanceWidgetProps) {
const useEap = useInsightsEap();

const queryExtras = useEap
? {...getMEPQueryParams(mepSetting), useRpc: '1', dataset: DiscoverDatasets.SPANS_EAP}
? {
...getMEPQueryParams(mepSetting),
...EAP_QUERY_PARAMS,
}
: getMEPQueryParams(mepSetting);

if (props.fields.length !== 1) {
Expand Down
Loading