fix(releases): Fix when project not yet loaded yet and drawer is opened #90829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix when project is undefined (not exactly sure when this happens)
github-actions
bot
added
the
Scope: Frontend
michellewzhang
approved these changes
May 2, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #90829 +/- ##
==========================================
- Coverage 87.80% 84.02% -3.78%
==========================================
Files 10283 10283
Lines 583590 583590
Branches 22579 22579
==========================================
- Hits 512407 490357 -22050
- Misses 70769 92819 +22050
Partials 414 414 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
…ed (#90829) Fix when project is undefined, I *believe* this happens when we load the page and drawer immediately opens before projects are fetched.
billyvg
added a commit
that referenced
this pull request
May 15, 2025
Was added in #90829, wanted to confirm I was fixing the correct bug. Confirmed, now removing.
billyvg
added a commit
that referenced
this pull request
May 15, 2025
Was added in #90829, wanted to confirm I was fixing the correct bug. Confirmed, now removing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix when project is undefined, I believe this happens when we load the page and drawer immediately opens before projects are fetched.