ref(usageStatsOrg): Convert component from class to function + useApiQuery#90884
Merged
priscilawebdev merged 16 commits intoMay 12, 2025
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
priscilawebdev
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #90884 +/- ##
==========================================
+ Coverage 87.63% 87.82% +0.19%
==========================================
Files 10324 10293 -31
Lines 585809 581955 -3854
Branches 22628 22417 -211
==========================================
- Hits 513396 511130 -2266
+ Misses 71985 70411 -1574
+ Partials 428 414 -14 |
priscilawebdev
force-pushed
the
priscila/ref/usage-stats-org/convert-from-class-to-func
branch
from
e267649 to
ea1d06f
Compare
priscilawebdev
commented
May 5, 2025
Comment on lines
-55
to
-60
| /** | ||
| * We allow 403s since we don't know if spike protection is enabled for the project or not | ||
| * If not, don't raise an error since we can still show usage data. | ||
| * We allow 404s in case they don't have access to new spike protection just yet | ||
| */ | ||
| const ALLOWED_STATUSES = new Set([403, 404]); |
Member
Author
There was a problem hiding this comment.
Now we are using useApiQuery and will not block the whole page if an endpoint fails. I believe this no longer makes sense
…' of github.com:getsentry/sentry into priscila/ref/usage-stats-org/convert-from-class-to-func
TkDodo
reviewed
May 6, 2025
…ion.tsx Co-authored-by: Dominik Dorfmeister <dominik.dorfmeister@sentry.io>
Co-authored-by: Dominik Dorfmeister <dominik.dorfmeister@sentry.io>
…' of github.com:getsentry/sentry into priscila/ref/usage-stats-org/convert-from-class-to-func
TkDodo
approved these changes
May 6, 2025
isabellaenriquez
approved these changes
May 6, 2025
|
|
||
| export interface UsageStatsOrganizationProps { | ||
| dataCategory: DataCategory; | ||
| dataCategoryApiName: DataCategoryInfo['apiName']; |
Contributor
There was a problem hiding this comment.
i know you didn't touch this in your pr but i think this type is wrong LOL, i can tackle this if you don't here though
Member
Author
There was a problem hiding this comment.
why do you think this type is wrong?
scttcper
reviewed
May 6, 2025
Comment on lines
+352
to
+360
| const orgStatsQuery = | ||
| endpointQuery ?? | ||
| getEndpointQuery({ | ||
| dataCategoryApiName, | ||
| dataDatetime, | ||
| organization, | ||
| projectIds, | ||
| endpointQueryDatetime: getEndpointQueryDatetime(dataDatetime), | ||
| }); |
Member
There was a problem hiding this comment.
this probably needs to be memoized if its being used as a dependency later since it will create a new object every render
scttcper
approved these changes
May 7, 2025
shellmayr
approved these changes
May 9, 2025
priscilawebdev
deleted the
priscila/ref/usage-stats-org/convert-from-class-to-func
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
…Query (#90884) Contributes to the initiative https://www.notion.so/sentry/Frontend-TSC-Project-Convert-DeprecatedAsyncComponent-to-FC-useApiQuery-1ac8b10e4b5d8050b8f0d4a62a08526b?cookie_sync_completed=true closes TET-376
Contributor
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to the initiative https://www.notion.so/sentry/Frontend-TSC-Project-Convert-DeprecatedAsyncComponent-to-FC-useApiQuery-1ac8b10e4b5d8050b8f0d4a62a08526b?cookie_sync_completed=true
closes TET-376
Note
Compared several data points against production, and everything looks good, but I appreciate more checks