Skip to content

chore(alerts-comparison): Optionally get confidence #90891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 5, 2025
Merged

chore(alerts-comparison): Optionally get confidence #90891

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
97fa0e3
feat: Track alert misfires on EAP
shruthilayaj May 1, 2025
50f3e05
account for that one missing bucket
shruthilayaj May 1, 2025
4d9e8f6
account for that one missing bucket
shruthilayaj May 1, 2025
8ef8663
don't raise no projects
shruthilayaj May 2, 2025
04b1d11
Merge branch 'master' into shruthi/feat/track-misfires-on-comparison
shruthilayaj May 2, 2025
915642f
chore(alerts-comparison): Optionally get confidence
shruthilayaj May 5, 2025
6ed7c49
merge conflicts
shruthilayaj May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/sentry/discover/compare_timeseries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ def get_mismatch_type(mismatches: dict[int, dict[str, float]], total_buckets: in
snql_value = values["snql_value"]
rpc_value = values["rpc_value"]
diff = values["mismatch_percentage"]
confidence = values["confidence"]
confidence = values.get("confidence")
sampling_rate = values.get("sampling_rate")

if snql_value > 0:
Expand Down Expand Up @@ -304,7 +304,7 @@ def assert_timeseries_close(aligned_timeseries, alert_rule):
"snql_value": snql_value,
"mismatch_percentage": diff,
"sampling_rate": values.get("sampling_rate"),
"confidence": values["confidence"],
"confidence": values.get("confidence"),
}

sentry_sdk.set_tag("false_positive_misfires", false_positive_misfire)
Expand Down Expand Up @@ -344,7 +344,7 @@ def compare_timeseries_for_alert_rule(alert_rule: AlertRule):
if not project:
return {"is_close": False, "skipped": True, "mismatches": {}}

if "apdex" in snuba_query.aggregate:
if "apdex" in snuba_query.aggregate or "percentile" in snuba_query.aggregate:
logger.info(
"Skipping alert %s, %s aggregate not yet supported by RPC",
alert_rule.id,
Expand Down
Loading