Skip to content

🔧 chore: add workflow_id to WorkflowEventData take 2#90978

Closed
iamrajjoshi wants to merge 1 commit into
masterfrom
raj/aci/add-workflow-id-wkflw-engine
Closed

🔧 chore: add workflow_id to WorkflowEventData take 2#90978
iamrajjoshi wants to merge 1 commit into
masterfrom
raj/aci/add-workflow-id-wkflw-engine

Conversation

@iamrajjoshi

Copy link
Copy Markdown
Collaborator

No description provided.

@iamrajjoshi iamrajjoshi self-assigned this May 5, 2025
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 5, 2025
@iamrajjoshi iamrajjoshi requested a review from saponifi3d May 5, 2025 23:26
)
continue

# Currently Actions aren't used in multiple workflows, so we can just use the first one

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can also do a check for len == 1

@codecov

codecov Bot commented May 5, 2025

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
25435 1 25434 332
View the top 1 failed test(s) by shortest run time
tests.sentry.workflow_engine.processors.test_delayed_workflow.TestFireActionsForGroups::test_fire_actions_for_groups__fire_actions
Stack Traces | 25.7s run time
#x1B[1m#x1B[.../workflow_engine/processors/test_delayed_workflow.py#x1B[0m:774: in test_fire_actions_for_groups__fire_actions
    assert mock_trigger.call_args_list[0][0] == (
#x1B[1m#x1B[31mE   assert (WorkflowEven...f3e90: id=48>) == (WorkflowEven...f0c50: id=48>)#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     At index 0 diff: WorkflowEventData(event=<sentry.eventstore.models.GroupEvent object at 0x7f75442b1db0>, group_state=None, has_reappeared=None, has_escalated=None, workflow_id=45, workflow_env=None) != WorkflowEventData(event=<sentry.eventstore.models.GroupEvent object at 0x7f75449311d0>, group_state=None, has_reappeared=None, has_escalated=None, workflow_id=None, workflow_env=None)#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Full diff:#x1B[0m
#x1B[1m#x1B[31mE       (#x1B[0m
#x1B[1m#x1B[31mE           WorkflowEventData(#x1B[0m
#x1B[1m#x1B[31mE     -         event=<sentry.eventstore.models.GroupEvent object at 0x7f75449311d0>,#x1B[0m
#x1B[1m#x1B[31mE     ?                                                                      ^^^#x1B[0m
#x1B[1m#x1B[31mE     +         event=<sentry.eventstore.models.GroupEvent object at 0x7f75442b1db0>,#x1B[0m
#x1B[1m#x1B[31mE     ?                                                                      ^^  +#x1B[0m
#x1B[1m#x1B[31mE               group_state=None,#x1B[0m
#x1B[1m#x1B[31mE               has_reappeared=None,#x1B[0m
#x1B[1m#x1B[31mE               has_escalated=None,#x1B[0m
#x1B[1m#x1B[31mE     -         workflow_id=None,#x1B[0m
#x1B[1m#x1B[31mE     ?                     ^^^^#x1B[0m
#x1B[1m#x1B[31mE     +         workflow_id=45,#x1B[0m
#x1B[1m#x1B[31mE     ?                     ^^#x1B[0m
#x1B[1m#x1B[31mE               workflow_env=None,#x1B[0m
#x1B[1m#x1B[31mE           ),#x1B[0m
#x1B[1m#x1B[31mE     -     <Detector at 0x7f751bdf0c50: id=48>,#x1B[0m
#x1B[1m#x1B[31mE     ?                            ^^^#x1B[0m
#x1B[1m#x1B[31mE     +     <Detector at 0x7f751bdf3e90: id=48>,#x1B[0m
#x1B[1m#x1B[31mE     ?                            ^^^#x1B[0m
#x1B[1m#x1B[31mE       )#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@iamrajjoshi iamrajjoshi closed this May 6, 2025
@iamrajjoshi

Copy link
Copy Markdown
Collaborator Author

closed in favor of https://github.com/getsentry/sentry/pull/91031/files

@github-actions github-actions Bot locked and limited conversation to collaborators May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant