feat(releases): Add project picker to releases drawer#91129
Merged
billyvg merged 13 commits intoMay 8, 2025
Merged
Conversation
If URL does not contain a project id (`rdReleaseProjectId`), then show a project picker before showing release details.
github-actions
Bot
added
the
Scope: Frontend
michellewzhang
left a comment
michellewzhang
left a comment
Contributor
There was a problem hiding this comment.
not related to this PR i think, but this table looks funky
Comment on lines
+105
to
+109
| await waitFor(() => { | ||
| expect(screen.queryByTestId('loading-indicator')).not.toBeInTheDocument(); | ||
| }); | ||
|
|
||
| expect(screen.getByText('Details')).toBeInTheDocument(); |
Contributor
There was a problem hiding this comment.
Suggested change
| await waitFor(() => { | |
| expect(screen.queryByTestId('loading-indicator')).not.toBeInTheDocument(); | |
| }); | |
| expect(screen.getByText('Details')).toBeInTheDocument(); | |
| expect(await screen.findByText('Details')).toBeInTheDocument(); |
does the test work if we await the text instead?
| } | ||
| }} | ||
| isClearable={false} | ||
| styles={{container: (base: any) => ({...base, marginTop: space(2)})}} |
Member
Author
There was a problem hiding this comment.
😭 i don't think we can style it otherwise (+ cursor did this)
| label: ( | ||
| <Link | ||
| to={{ | ||
| query: locationQueryWithoutRelease, |
Contributor
There was a problem hiding this comment.
Screen.Recording.2025-05-07.at.1.26.50.PM.mov
this crumb breaks for me, coming from the table on session health
Contributor
There was a problem hiding this comment.
url of broken drawer is https://xxx.sentry.dev/insights/mobile/sessions/?rd=show&statsPeriod=90d
Contributor
There was a problem hiding this comment.
the crumb works ok if the entrypoint is the release bubbles though!
Member
Author
There was a problem hiding this comment.
Ah good find, it requires start/end dates to show the Releases list
…eases-details-drawer
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
michellewzhang
approved these changes
May 8, 2025
billyvg
deleted the
billy/replay-195-add-project-picker-to-releases-details-drawer
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
If URL does not contain a project id (`rdReleaseProjectId`), then show a project picker before showing release details (if the release belongs to multiple projects). <img width="958" alt="image" src="https://github.com/user-attachments/assets/e2dbcda9-9e9f-425f-8f97-d4f2ab95e7a8" /> With project selected, we show all projects in the header and allow user to switch projects by clicking on a badge: <img width="958" alt="image" src="https://github.com/user-attachments/assets/b1456c0e-31e7-412e-a5b3-9898dd00d3a5" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If URL does not contain a project id (
rdReleaseProjectId), then show a project picker before showing release details (if the release belongs to multiple projects).With project selected, we show all projects in the header and allow user to switch projects by clicking on a badge: