Skip to content

Conversation

@korolenkowork
Copy link
Contributor

This PR upgrade celery version to avoid bug finded in Issue getsentry/self-hosted#3699

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@korolenkowork korolenkowork requested a review from a team as a code owner May 9, 2025 12:55
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 9, 2025
@asottile-sentry
Copy link
Contributor

getsentry/pypi#1433 will add the latest celery to our pypi so this can at least proceed to run tests

note that we're in the process of factoring celery out so that may also trivially solve your problem when it lands

@korolenkowork
Copy link
Contributor Author

@asottile-sentry Thanks for your response! I'm pretty sure that replacing Celery will solve my problem. But I've been running into a lot of issues with this lately, so I’d really appreciate a solution like this as soon as possible.

@asottile-sentry asottile-sentry force-pushed the feature/update-celery-version branch from ef265be to 36f80d8 Compare May 9, 2025 21:08
@asottile-sentry
Copy link
Contributor

it looks like you'll need to run make freeze-requirements until there are no dependency conflicts

@korolenkowork
Copy link
Contributor Author

Done!

@asottile-sentry asottile-sentry added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label May 10, 2025
Copy link
Contributor

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might take us to an intermediate version first just to be a little safer. we've had some annoying breakages with celery in the past

@github-actions github-actions bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label May 12, 2025
@asottile-sentry
Copy link
Contributor

hi! this will need a rebase as I've upgraded most of the non-celery deps to reduce the risk of this

@korolenkowork
Copy link
Contributor Author

@asottile-sentry updated!

@korolenkowork
Copy link
Contributor Author

Hey, @asottile-sentry! Are there any updates on this?

@asottile-sentry asottile-sentry added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jun 3, 2025
Copy link
Contributor

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile-sentry asottile-sentry enabled auto-merge (squash) June 5, 2025 13:44
@asottile-sentry asottile-sentry merged commit 7653f01 into getsentry:master Jun 5, 2025
58 of 60 checks passed
@asottile-sentry
Copy link
Contributor

thanks again! this has rolled out and will be available in the next self-hosted release (likely 25.6.0)

andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
…ection to MQBroker (#91330)

This PR upgrade celery version to avoid bug finded in Issue
getsentry/self-hosted#3699

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

---------

Co-authored-by: Ihor <88674695+EnotShow@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants