fix(taskworker) Remove unused union arms and cleanup #91394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove now unused variants of parameter unions. As part of the de-pickling of our task parmeters unions were introduced, and we can now remove those unions and simplify logic. This helps unblock #91391
github-actions
bot
added
the
Scope: Backend
wedamija
approved these changes
May 9, 2025
evanh
approved these changes
May 12, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #91394 +/- ##
==========================================
+ Coverage 87.62% 87.64% +0.01%
==========================================
Files 10312 10313 +1
Lines 586043 585644 -399
Branches 22616 22569 -47
==========================================
- Hits 513514 513275 -239
+ Misses 72086 71941 -145
+ Partials 443 428 -15 |
Member
Author
|
reverted because of an error on s4s. |
Contributor
|
PR reverted: 5a4461b |
getsentry-bot
added a commit
that referenced
this pull request
May 13, 2025
This reverts commit 81e87a0. Co-authored-by: markstory <24086+markstory@users.noreply.github.com>
markstory
added a commit
that referenced
this pull request
May 13, 2025
Redo of the changes from #91394 without the email task changes. There was an error in s4s from email tasks, and I'd like to understand the failure better before making any further changes.
markstory
added a commit
that referenced
this pull request
May 13, 2025
Redo of the changes from #91394 without the email task changes. There was an error in s4s from email tasks, and I'd like to understand the failure better before making any further changes.
markstory
added a commit
that referenced
this pull request
May 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove now unused variants of parameter unions. As part of the de-pickling of our task parmeters unions were introduced, and we can now remove those unions and simplify logic.
This helps unblock #91391