ref(feedback): Add user.geo fields to feedback tags display and alphabetize tags #91405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
aliu39
commented
May 9, 2025
|
|
||
| export default function TagsSection({tags}: Props) { | ||
| const entries = Object.entries(tags); | ||
| const orderedEntries = orderBy(Object.entries(tags), ['key'], ['asc']); |
Member
Author
There was a problem hiding this comment.
previously no guarantee on order (tags is unordered)
aliu39
commented
May 9, 2025
Comment on lines
-53
to
-58
| ...(eventTags.some(e => e.key === 'environment') | ||
| ? {environment: eventTags.find(e => e.key === 'environment')?.value} | ||
| : {}), | ||
| ...(eventTags.some(e => e.key === 'transaction') | ||
| ? {transaction: eventTags.find(e => e.key === 'transaction')?.value} | ||
| : {}), |
Member
Author
There was a problem hiding this comment.
Already covered by line 37-44
billyvg
approved these changes
May 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested follow up to #91269. These technically aren't tags but are searchable.