ref: handle old malformed ArrayField values in export / import #91410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #91410 +/- ##
===========================================
+ Coverage 67.05% 87.63% +20.58%
===========================================
Files 10311 10314 +3
Lines 585871 586084 +213
Branches 22603 22603
===========================================
+ Hits 392830 513636 +120806
+ Misses 192613 72020 -120593
Partials 428 428 |
asottile-sentry
force-pushed
the
asottile-import-export-fixup-array-fields
branch
from
22986ee to
83f171e
Compare
asottile-sentry
force-pushed
the
asottile-import-export-fixup-array-fields
branch
from
83f171e to
19d4d9b
Compare
asottile-sentry
force-pushed
the
asottile-import-export-fixup-array-fields
branch
from
19d4d9b to
e74f366
Compare
asottile-sentry
force-pushed
the
asottile-import-export-fixup-array-fields
branch
from
e74f366 to
c173e26
Compare
asottile-sentry
force-pushed
the
asottile-import-export-fixup-array-fields
branch
from
c173e26 to
26cd1cb
Compare
asottile-sentry
force-pushed
the
asottile-import-export-fixup-array-fields
branch
from
26cd1cb to
6d8ddef
Compare
markstory
approved these changes
May 12, 2025
Comment on lines
+96
to
+97
| # preserve for 3 versions as per https://docs.sentry.io/concepts/migration/#version-support-window | ||
| # so probably 2025.09 this can go away? |
Member
There was a problem hiding this comment.
We'll probably need to keep this around much longer, as sales often works with customers on much older sentry versions 😢
Contributor
Author
There was a problem hiding this comment.
should we.... update the policy to reflect that then?
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
<!-- Describe your PR here. -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.