fix(compare-alerts): Add some better timestamp rounding logic #91433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
nikkikapadia
approved these changes
May 12, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
EAP timeseries don't round time buckets to the nearest time window snql does, So for example, if start was 7:01 with a 15 min interval, EAP would bucket it as 7:01, 7:16 etc. Force rounding the start and end times so we get the buckets snql returns so we can match time buckets.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EAP timeseries don't round time buckets to the nearest time window snql does,
So for example, if start was 7:01 with a 15 min interval, EAP would
bucket it as 7:01, 7:16 etc. Force rounding the start and end times so we
get the buckets snql returns so we can match time buckets.