chore(integrations): Changes exception type for missing org integrations, updates assignment sync to halt on this exception#91542
Merged
GabeVillalobos merged 2 commits intoMay 15, 2025
Conversation
…ons, updates assignment sync to halt on this exception
github-actions
Bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #91542 +/- ##
===========================================
+ Coverage 45.40% 87.64% +42.23%
===========================================
Files 10299 10321 +22
Lines 585388 586474 +1086
Branches 22602 22602
===========================================
+ Hits 265804 514013 +248209
+ Misses 319156 72033 -247123
Partials 428 428 |
…est to validate new exception type
cathteng
approved these changes
May 14, 2025
Contributor
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ECO-507
Updates the exception type raised in the base
IntegrationInstallationclass to a distinct type, handles this case when choosing an SLO outcome insync_assignment_outboundtasks to ensure that missing org integrations are treated as halts, not failures.