fix(widget-builder): Bring the title and description to the top#91652
Conversation
Brings the title and description field to the top and adjusts some styles to make sure it renders similarly to the other sections
Brings the title and description field to the top and adjusts some styles to make sure it renders similarly to the other sections
…f github.com:getsentry/sentry into narsaynorath/dain-430-bring-widget-title-back-to-top
github-actions
Bot
added
the
Scope: Frontend
nikkikapadia
left a comment
nikkikapadia
left a comment
There was a problem hiding this comment.
couple of comments mainly on the responsive views
| <FilterBarContainer {...animatedProps}> | ||
| <WidgetBuilderFilterBar releases={dashboard.filters?.release ?? []} /> | ||
| </FilterBarContainer> | ||
| )} |
There was a problem hiding this comment.
On small responsive screens there needs to be a condition to keep the filter bar at the top of the slideout (like how it is now) because with this it's not present on the responsive view.
There was a problem hiding this comment.
I added it to the smaller breakpoint view 👍 It's really cramped, but I don't want to muck with the styling right now lol it's already like this in prod so I'll loop back around to it. Same applies to your other comment right now
| animate={{opacity: 1, x: 0, y: 0}} | ||
| exit={{opacity: 0, x: '50%', y: 0}} | ||
| transition={animationTransitionSettings} | ||
| {...animatedProps} |
There was a problem hiding this comment.
I'm noticing the widget preview is no longer centered. Also the filter bar gets cut off if the screen gets too small. We can assign the filter bar a responsive width to match the widget preview.
narsaynorath
deleted the
narsaynorath/dain-430-bring-widget-title-back-to-top
branch
2 participants
Brings the title and description field to the top and adjusts some
styles to make sure it renders similarly to the other sections
I also added an
idto the releases select control so I could override some of its styling with chonk UI. It's not the most robust but it works for now and maybe I'll look at pushing the change into filter bars generally. The issue was that each button gets translated to the left slightly to overlap the borders, but by the end of the widget there's now-n pxof space. I've just extended the last trigger by 3px to account for the difference.