ref(replay): Refactor loading and error states for Replay Details page #92230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
…ut is based on replayRecord
billyvg
approved these changes
May 26, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
#92230) The only real visible changes are related to the header in error and loading scenarios, and padding in the Archived state. Nav breadrcumbs now filter empty labels in all cases, prefering to show "Session Replay" instead of "Session Replay > >" while loading. The color contract of placeholders in the header is terrible, but they're all present with the same dimensions as before. | State | Before | After | | --- | --- | --- | | Archived/Deleted | <img width="1309" alt="archived-before" src="https://github.com/user-attachments/assets/4665a048-c6b9-48be-abeb-474dce2918c4" /> | <img width="1312" alt="archived-after" src="https://github.com/user-attachments/assets/6d1e3415-e141-497a-9a1a-5b6bb3067306" /> | Not Found | <img width="1309" alt="not-found-before" src="https://github.com/user-attachments/assets/cef3a63e-1947-45f3-a23c-645f160ff7a6" /> | <img width="1308" alt="not-found-after" src="https://github.com/user-attachments/assets/851b8f90-c499-42a9-a00b-589dbc16fb1e" /> | Loading | https://github.com/user-attachments/assets/87014604-329b-4b82-9a8e-d11c5b925808 | https://github.com/user-attachments/assets/716a31fe-0316-4c3e-8140-07d04c2f621e
This was referenced Jun 6, 2025
ryan953
added a commit
that referenced
this pull request
Jun 6, 2025
This broke from the changes in #92230 What we need is to hoist the `<ReplayContext>` up so it wraps the header and main part of the page again. Fixes 93032
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only real visible changes are related to the header in error and loading scenarios, and padding in the Archived state. Nav breadrcumbs now filter empty labels in all cases, prefering to show "Session Replay" instead of "Session Replay > >" while loading.
The color contract of placeholders in the header is terrible, but they're all present with the same dimensions as before.