fix(detectors): Fix type error in SQL Injection Detector #92683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #92683 +/- ##
===========================================
+ Coverage 46.21% 87.89% +41.68%
===========================================
Files 10234 10250 +16
Lines 587244 587929 +685
Branches 22829 22829
===========================================
+ Hits 271367 516782 +245415
+ Misses 315431 70701 -244730
Partials 446 446 |
JoshFerge
approved these changes
Jun 3, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 3, 2025
assumed that the value in the request query/body was a string, which is not always true. we only care about strings for this detector so we can skip any values that aren't strings.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assumed that the value in the request query/body was a string, which is not always true. we only care about strings for this detector so we can skip any values that aren't strings.