ref(feedback): infer user fields from event in v1 shims #92688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92688 +/- ##
===========================================
+ Coverage 46.21% 87.90% +41.68%
===========================================
Files 10234 10250 +16
Lines 587244 587981 +737
Branches 22829 22829
===========================================
+ Hits 271371 516838 +245467
+ Misses 315427 70697 -244730
Partials 446 446 |
aliu39
commented
Jun 3, 2025
| assert evidence["is_spam"] is True | ||
|
|
||
|
|
||
| @django_db_all |
michellewzhang
approved these changes
Jun 3, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 3, 2025
Feature requested in - getsentry/sentry-native#1264 Reading the user fields from the event based on https://github.com/getsentry/sentry/blob/eeee98ba851fa4219f998a4f41030e3eaaef289d/src/sentry/issues/event.schema.json#L2974 Note this isn't done for feedback v2 (`captureFeedback`). This is trickier since we don't have the event data at ingest time.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature requested in
sentry_value_new_user_feedbackthat only requires parent event uuid and comments and grabs the user name and email from the parent event sentry-native#1264Reading the user fields from the event based on
sentry/src/sentry/issues/event.schema.json
Line 2974 in eeee98b
Note this isn't done for feedback v2 (
captureFeedback). This is trickier since we don't have the event data at ingest time.