🔧 chore(msteams): mark resolve in upcoming release errors as halt #92689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #92689 +/- ##
===========================================
+ Coverage 42.17% 87.89% +45.72%
===========================================
Files 10226 10251 +25
Lines 586770 587923 +1153
Branches 22826 22826
===========================================
+ Hits 247451 516757 +269306
+ Misses 338887 70734 -268153
Partials 432 432 |
Christinarlong
approved these changes
Jun 3, 2025
| user=user_service.get_user(user_id=identity.user_id), | ||
| auth=event_write_key, | ||
| ) | ||
| except client.ApiError as e: |
Contributor
There was a problem hiding this comment.
curious Q is there a difference between client.ApiError vs ApiError?
Collaborator
Author
There was a problem hiding this comment.
this is a different ApiError, the one we usually use is from shared_exceptions, so we need to annotate client here
Comment on lines
+509
to
+510
| elif e.status_code >= 400: | ||
| lifecycle.record_failure(e) |
Contributor
There was a problem hiding this comment.
nit: thoughts on letting the error through and triggering the lifecycle/recording failure on its own ? (Curious on your thoughts since I've seen both ways)
Collaborator
Author
There was a problem hiding this comment.
i think its stylistic atp
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mark errors like
sentry.api.client.ApiError: status=400 body={'statusDetails': {'inNextRelease': [ErrorDetail(xxx]}}"as halts because it means the user hasn't configured releases correctly.also actually capture the other
haltandfailurecases correctly b/c we weren't doing that beforecloses ECO-576