chore(github): Validate the same org is installing #92694
Merged
+66
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
leeandher
approved these changes
Jun 3, 2025
| and installing_organization_slug | ||
| == self.active_user_organization.organization.slug | ||
| ) | ||
| if not has_scm_multi_org or not is_same_installing_org: |
Member
There was a problem hiding this comment.
Good catch! But should we handle this with a separate error more generally, like break the pipeline if the user is seeing resources from a different organization after re-fetching? I'll leave it to you but I think that switching organizations mid installation is totally fine to break the installation flow.
Contributor
Author
There was a problem hiding this comment.
ooo that makes sense uh, I just would need to figure out how to do that in the frontend :hides:
shellmayr
pushed a commit
that referenced
this pull request
Jun 12, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was testing the frontend for the multi org flow, I realized I could
It looks like in the pipeline, Org2 was being used as the active organization, but the installation still installed on Org1 🤷♀️