feat(debugger-modal): Make 'debug ID' clickable and link to settings #92714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
…ug-ids-in-debugger-modal
| to={{ | ||
| pathname: `/settings/projects/${projectSlug}/source-maps/`, | ||
| query: { | ||
| query: debugId, |
Contributor
There was a problem hiding this comment.
can we just do something like debugId! here to get rid of the unnecessary case above?
Member
Author
There was a problem hiding this comment.
we can. but I usually avoid the usage of !
Comment on lines
+1291
to
+1293
| aria-label={t('View source map Debug ID %(debugId)s in project settings', { | ||
| debugId, | ||
| })} |
Contributor
There was a problem hiding this comment.
Suggested change
| aria-label={t('View source map Debug ID %(debugId)s in project settings', { | |
| debugId, | |
| })} | |
| aria-label={t('View source map Debug ID %(debugId)s in project settings', { | |
| debugId, | |
| })} |
can we just use tct here or is t preferred?
Member
Author
There was a problem hiding this comment.
we need to always have a string for aria-labels, and tct returns a React Node
scttcper
reviewed
Jun 3, 2025
| )} | ||
| <DebugIdMismatchMessage | ||
| projectSlug={projectSlug} | ||
| debugId={sourceResolutionResults.stackFrameDebugId} |
Member
There was a problem hiding this comment.
add sourceResolutionResults.stackFrameDebugId to the if and make debugId non-nullable
Member
Author
There was a problem hiding this comment.
I want to ensure this part of the code always renders, even if debugID is null - which shouldn't happen, but just in case. That's why we need to fix the types.
scttcper
reviewed
Jun 3, 2025
Comment on lines
+1265
to
+1277
| debugId: string | null; | ||
| projectSlug?: string; | ||
| }) { | ||
| // At this point debugId is always defined. The types need to be fixed | ||
| if (!debugId) { | ||
| return ( | ||
| <Fragment> | ||
| {t( | ||
| "You already uploaded artifacts with Debug IDs but none of the uploaded source files had a Debug ID matching this stack frame's Debug ID" | ||
| )} | ||
| </Fragment> | ||
| ); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| debugId: string | null; | |
| projectSlug?: string; | |
| }) { | |
| // At this point debugId is always defined. The types need to be fixed | |
| if (!debugId) { | |
| return ( | |
| <Fragment> | |
| {t( | |
| "You already uploaded artifacts with Debug IDs but none of the uploaded source files had a Debug ID matching this stack frame's Debug ID" | |
| )} | |
| </Fragment> | |
| ); | |
| } | |
| debugId: string; | |
| projectSlug?: string; | |
| }) { |
obostjancic
approved these changes
Jun 4, 2025
priscilawebdev
deleted the
priscila/feat/source-maps/add-links-to-debug-ids-in-debugger-modal
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
Screen.Recording.2025-06-03.at.09.38.45.mov
closes TET-363