chore(plugins): undeprecate Heroku #92981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Member
Author
|
The backend frontend scope is false positive. None of these will break the other if they deploy faster. |
iamrajjoshi
approved these changes
Jun 6, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
This is reverting a part of what I did in #91550 It turned out Heroku plugin is needed for Heroku partnership and people keep creating new projects with it. I have to bring back add to project button so people are unblocked while we find another solution. I didn't bring back all the code, just these two views. <img width="916" alt="Screenshot 2025-06-05 at 12 28 38 PM" src="https://github.com/user-attachments/assets/49911c91-17e9-4b7d-bca9-bb5c859a538b" /> <img width="910" alt="Screenshot 2025-06-05 at 12 28 46 PM" src="https://github.com/user-attachments/assets/c4efe14b-7faf-4039-b2bb-b8bd91623f1a" />
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is reverting a part of what I did in #91550
It turned out Heroku plugin is needed for Heroku partnership and people keep creating new projects with it. I have to bring back add to project button so people are unblocked while we find another solution.
I didn't bring back all the code, just these two views.