feat(sampling) - Changed times_seen increments on groups to take error sample rate into account #93003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r sample rate into account
github-actions
bot
added
the
Scope: Backend
armenzg
approved these changes
Jun 6, 2025
yuvmen
force-pushed
the
yuvmen/extrapolated-times-seen-on-error-issues
branch
from
161c7d9 to
9d3aa38
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93003 +/- ##
========================================
Coverage 87.90% 87.90%
========================================
Files 10289 10289
Lines 590621 590788 +167
Branches 22961 22961
========================================
+ Hits 519161 519335 +174
+ Misses 71013 71006 -7
Partials 447 447 |
armenzg
approved these changes
Jun 6, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…r sample rate into account (#93003) As part of error extrapolation/upsampling we need to now make sure the times_seen on groups is calculated correctly on projects where events have a sample rate. Now in event manager for projects in the allowlist we increment times_seen not be 1 but by the inverse of sample_rate, both when creating a new group and when saving a new event.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of error extrapolation/upsampling we need to now make sure the times_seen on groups is calculated correctly on projects where events have a sample rate.
Now in event manager for projects in the allowlist we increment times_seen not be 1 but by the inverse of sample_rate, both when creating a new group and when saving a new event.