ref(symbolicator): only fetch gcp token if no private_key is configured #93010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
loewenheim
approved these changes
Jun 6, 2025
oioki
approved these changes
Jun 10, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
vishnupsatish
pushed a commit
that referenced
this pull request
Jun 12, 2025
…ed (#93010) This PR changes the order of operations for obtaining GCP token. Instead of attempting to fetch it in all cases, it will only try to obtain it if no `private_key` is defined. This way we can ensure that previously configured projects work as before without having to unnecessary attempt to fetch the token. By restoring the old behaviour for sources with `client_email` and `private_key`, it allows us to remove the feature flag.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
…ed (#93010) This PR changes the order of operations for obtaining GCP token. Instead of attempting to fetch it in all cases, it will only try to obtain it if no `private_key` is defined. This way we can ensure that previously configured projects work as before without having to unnecessary attempt to fetch the token. By restoring the old behaviour for sources with `client_email` and `private_key`, it allows us to remove the feature flag.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the order of operations for obtaining GCP token. Instead of attempting to fetch it in all cases, it will only try to obtain it if no
private_keyis defined.This way we can ensure that previously configured projects work as before without having to unnecessary attempt to fetch the token.
By restoring the old behaviour for sources with
client_emailandprivate_key, it allows us to remove the feature flag.